Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filtering out URLs whose parsing encounter UnicodeDecodeError #16

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Filtering out URLs whose parsing encounter UnicodeDecodeError #16

wants to merge 2 commits into from

Conversation

Arduous
Copy link
Contributor

@Arduous Arduous commented Aug 12, 2018

This is a proposal to protect from exceptions described in bug #6 .

Commits are messy :/ but at the end of the day, changes are really limited.

@Arduous Arduous changed the title Filtering out URs whose parsing encounter UnicodeDecodeError Filtering out URLs whose parsing encounter UnicodeDecodeError Aug 13, 2018
@Arduous Arduous force-pushed the PRforbug6 branch 3 times, most recently from c9cb167 to 78d935c Compare August 31, 2018 22:07
@Arduous
Copy link
Contributor Author

Arduous commented Aug 31, 2018

Hello, I did some cleanup in my commits. Any chance to get this pull request accepted?

Thank you

@1tayH
Copy link
Owner

1tayH commented Sep 7, 2018

Hi, so sorry, been super busy with work lately

I'll try to reproduce this and get a better understanding of what's actually happening there, will merge once I confirm this solves it 😄

Thanks for the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Arduous @1tayH